Open
Conversation
due to difficulty it will only perform once. refactor renamed the ordealCallRegion into closeLowerMiddleScreenRegion add EN the version of coordinates there
…er taken are full
…etching of embers for the loop Return the Exception for picking embers, needed it when it was not looping
added check if the script is lottery before doing the function
Collaborator
Author
output_video.mp4 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the lottery-gift box loop functionality by adding new configuration options and exit flows to support looping back to the lottery after processing the gift box. Key changes include:
- Addition of new preferences (loopIntoLotteryAfterPresentBox, isPresentBoxFull, lottoSpin) and corresponding UI elements.
- Updates to exit reasons and control flow in AutoLottery.kt and AutoGiftBox.kt to manage the looping behavior.
- Adjustments in region usage and UI responses across various modules to support the new logic.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/src/main/java/io/github/fate_grand_automata/scripts/prefs/IPreferences.kt | Added new preference properties for lottery loop and gift box state. |
| scripts/src/main/java/io/github/fate_grand_automata/scripts/locations/Locations.kt | Replaced ordealCallOutOfPodsRegion with closeLowerMiddleScreenRegion using a when() construct. |
| scripts/src/main/java/io/github/fate_grand_automata/scripts/entrypoints/AutoLottery.kt | Modified exit reasons and control flow in presentBoxFull() and spin() to support gambling loop logic. |
| scripts/src/main/java/io/github/fate_grand_automata/scripts/entrypoints/AutoGiftBox.kt | Updated handling to return to lottery and throw appropriate exit exceptions. |
| app/src/main/res/values/localized.xml | Added new string resources for the experimental lottery loop feature. |
| Remaining files | Updated UI and configuration handling to integrate the new lottery loop and gift box features. |
scripts/src/main/java/io/github/fate_grand_automata/scripts/entrypoints/AutoLottery.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.